31cb50b559
The 'static' specifier and EXPORT_SYMBOL() are an odd combination. Commit15bfc2348d("modpost: check for static EXPORT_SYMBOL* functions") tried to detect it, but this check has false negatives. Here is the sample code. Makefile: obj-y += foo1.o foo2.o foo1.c: #include <linux/export.h> static void foo(void) {} EXPORT_SYMBOL(foo); foo2.c: void foo(void) {} foo1.c exports the static symbol 'foo', but modpost cannot catch it because it is fooled by foo2.c, which has a global symbol with the same name. s->is_static is cleared if a global symbol with the same name is found somewhere, but EXPORT_SYMBOL() and the global symbol do not necessarily belong to the same compilation unit. This check should be done per compilation unit, but I do not know how to do it in modpost. modpost runs against vmlinux.o or modules, which merges multiple objects, then forgets their origin. modpost cannot parse individual objects because they may not be ELF but LLVM IR when CONFIG_LTO_CLANG=y. Add a simple bash script to parse the output from ${NM}. This works for CONFIG_LTO_CLANG=y because llvm-nm can dump symbols of LLVM IR files. Revert15bfc2348d. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Tested-by: Nathan Chancellor <nathan@kernel.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
1.7 KiB
Executable File
#!/bin/bash
SPDX-License-Identifier: GPL-2.0-only
Copyright (C) 2022 Masahiro Yamada masahiroy@kernel.org
Exit with error if a local exported symbol is found.
EXPORT_SYMBOL should be used for global symbols.
set -e
declare -A symbol_types declare -a export_symbols
exit_code=0
while read value type name do # Skip the line if the number of fields is less than 3. # # case 1) # For undefined symbols, the first field (value) is empty. # The outout looks like this: # " U _printk" # It is unneeded to record undefined symbols. # # case 2) # For Clang LTO, llvm-nm outputs a line with type 't' but empty name: # "---------------- t" if -z ${name} ; then continue fi
# save (name, type) in the associative array
symbol_types[${name}]=${type}
# append the exported symbol to the array
if [[ ${name} == __ksymtab_* ]]; then
export_symbols+=(${name#__ksymtab_})
fi
# If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm)
# shows 'no symbols' diagnostic (but exits with 0). It is harmless and
# hidden by '2>/dev/null'. However, it suppresses real error messages
# as well. Add a hand-crafted error message here.
#
# Use --quiet instead of 2>/dev/null when we upgrade the minimum version
# of binutils to 2.37, llvm to 13.0.0.
#
# Then, the following line will be really simple:
# done < <(${NM} --quiet ${1})
done < <(${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } )
Catch error in the process substitution
wait $!
for name in "${export_symbols[@]}" do # nm(3) says "If lowercase, the symbol is usually local" if ; then echo "$@: error: local symbol '${name}' was exported" >&2 exit_code=1 fi done
exit ${exit_code}