linux-yocto/drivers/gpu/drm/tilcdc/Makefile
Masahiro Yamada 163ba35ff3 doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line
You should use KCFLAGS to pass additional compiler flags from the
command line. Using EXTRA_CFLAGS is wrong.

EXTRA_CFLAGS is supposed to specify flags applied only to the current
Makefile (and now deprecated in favor of ccflags-y).

It is still used in arch/mips/kvm/Makefile (and possibly in external
modules too). Passing EXTRA_CFLAGS from the command line overwrites
it and breaks the build.

I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1f
("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in
EXTRA_CFLAGS") was based on the same misunderstanding.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com>
Acked-by: Federico Vaga <federico.vaga@vaga.pv.it>
Link: https://lore.kernel.org/r/20210221152524.197693-1-masahiroy@kernel.org
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
2021-02-22 13:59:10 -07:00

241 B

SPDX-License-Identifier: GPL-2.0

ifeq (, $(findstring -W,$(KCFLAGS))) ccflags-y += -Werror endif

tilcdc-y :=
tilcdc_plane.o
tilcdc_crtc.o
tilcdc_panel.o
tilcdc_external.o
tilcdc_drv.o

obj-$(CONFIG_DRM_TILCDC) += tilcdc.o